![]() Possibilities include your initials, or an abbreviation for the name of your organization or software package. > To ensure that your macros don't conflict with present or future Autoconf macros, you should prefix your own macro names and any shell variables they use with some other sequence. Setting things like ac_have_builtin_ctz is therefore equally uncool. * Shell variables starting with ac_ are in autoconf's namespace. $(CXXFLAGS) $(libsnappy_la_LDFLAGS) $(LDFLAGS) -o There should be an AC_ARG_WITH for gflags, because automagic dependencies aren't cool: $(LIBTOOLFLAGS) -mode=link $(CXXLD) $(AM_CXXFLAGS) \ Libsnappy_la_LINK = $(LIBTOOL) -tag=CXX $(AM_LIBTOOLFLAGS) \ If it's to allow the user to provide custom LDFLAGS, it's unnecessary: LDFLAGS is part of libsnappy_la_LINK. It'd be more conventional to do something like:Īnd set the -version-info flag directly in Makefile.am. * The dance with EXTRA_LIBSNAPPY_LDFLAGS seems odd. It'll probably work fine, but it's poor style. ![]() * Needs to call AC_SUBST() or else the rule to rebuild libtool in Makefile.am won't work. That's INSTALL Makefile.in aclocal.m4 compile config.guess config.h.in config.sub configure depcomp install-sh ltmain.sh missing mkinstalldirs. ![]() autoreconf -i works really well these days. * The various bits generated from and added by the autotools shouldn't be committed. IMHO, the build system could do with a little work: Please someone port it to C and linux-kernel code so it could be used with zram instead of LZO. ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |